Add support for changing currency in Settings #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stripe is now available in Canada so you are now able to choose to process in either American ("usd") and Canadian ("cad") currency.
At the moment, "usd" is hard-coded as the currency variable in several spots which causes errors if your account is set to "cad". These changes allow the currency to be set as one of the variables in PAYMENT_PLANS.
paltman
added a commit
that referenced
this pull request
Jan 26, 2013
Add support for changing currency in Settings
|
@huxley thanks for the awesome patch |
blueyed
pushed a commit
to blueyed/pinax-stripe
that referenced
this pull request
Oct 24, 2017
* Add discount objects * Add coupon webhook handlers * Change Coupon id unique-togetherness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stripe is now available in Canada so vendors are now able to choose to process in either American ("usd") and Canadian ("cad") currency.
At the moment, "usd" is hard-coded as the currency variable which causes errors if your account is set to "cad". I've added currency as one of the variables in PAYMENT_PLANS allowing customers processing in Canadian dollars to specify "cad".
Stripe only allows one currency per account (this might change in the long term), so an alternative way to achieve this might be to set a single setting for PAYMENTS_CURRENCY, but I opted to minimize the number of SETTINGS and instead removed the hard-coding.