Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ZenodoReader which doesn't rely on the UNFCCC Api #79

Merged
merged 12 commits into from
Jul 18, 2023
Merged

Conversation

mikapfl
Copy link
Member

@mikapfl mikapfl commented Jul 18, 2023

The ZenodoReader fetches data from zenodo instead of the UNFCCC API and presents a similar interface.

@mikapfl mikapfl requested a review from JGuetschow July 18, 2023 09:51
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #79 (529ec4b) into main (48650f5) will increase coverage by 0.15%.
The diff coverage is 95.91%.

@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
+ Coverage   93.83%   93.98%   +0.15%     
==========================================
  Files           3        3              
  Lines         227      266      +39     
==========================================
+ Hits          213      250      +37     
- Misses         14       16       +2     
Impacted Files Coverage Δ
unfccc_di_api/unfccc_di_api.py 92.41% <92.00%> (-0.10%) ⬇️
unfccc_di_api/__init__.py 100.00% <100.00%> (ø)
unfccc_di_api/tests/test_unfccc_di_api.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link

@JGuetschow JGuetschow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
I would add comments about the partial implementation.
And I don't understand how we will deal with data updates on zenodo

unfccc_di_api/unfccc_di_api.py Show resolved Hide resolved
unfccc_di_api/unfccc_di_api.py Show resolved Hide resolved
unfccc_di_api/unfccc_di_api.py Show resolved Hide resolved
@mikapfl mikapfl merged commit 16e68c2 into main Jul 18, 2023
9 checks passed
@mikapfl mikapfl deleted the zenodo branch July 18, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants