Fix handling of duplicate variableids #31
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #28
Minimal changes to fix the handling of duplicate variable IDs. This entails changes to the public
API! In particular,
UNFCCCSingleCategoryApiReader.variables
now has a generic indexinstead of using the
variableId
as index. Also, thequery
function nowcorrectly restricts queries if
category_ids
are provided and correctly fillsall categories with data for a multi-category variable.
This should lead to more correct and complete data returned in some situations.
NB: I also checked again if the same data is returned when using different category_ids for the same category, and no. The two "other" categories (with or without lulucf) are very different. I hope it is correct to return both as the same category when querying? I don't know, though.