Accept and return (optional) ASCII format for gases and units #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2 +/- ##
==========================================
+ Coverage 89.77% 90.57% +0.80%
==========================================
Files 2 2
Lines 176 191 +15
==========================================
+ Hits 158 173 +15
Misses 18 18
Continue to review full report at Codecov.
|
|
Fighting the CI can be avoided by running "make lint" in the repo before committing. 🙂 It is also possible to set up pre-commit to run automatically on git commits, the docs explain how. |
Like this, normalization is available at all levels of abstraction.
|
Thanks for the PR, looks good! |
|
I have released a new version incorporating your changes. So if you want to drop the normalization from your pyam PR, you might want to use a versioned dependency Cheers + thanks again, Mika |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings in a generalization of the API, per a comment by @mikapfl, see IAMconsortium/pyam#497 (comment).
The `UNFCCCApiReader.query()´ now accepts simple ASCII-strings of gases (N2O instead of N₂O), and optionally (default) returns the gases and unit columns normalized to ASCII.
Note: Not sure if 'C5F₁₂' in the UNFCCC API is a bug or a feature, but I figured that the explicit dictionary is preferable (more readable) to a "make everything subscript except for ..." function.