-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gas categorization. #1
Conversation
So far, only emission rates derived from openscm_units are included. What else do we need? PRIMAP1 contains a lot of categories with (for me) kind of dubious codes and definitions like So far I understood that we definitely need:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I made some comments on possible additional fields (probably too much work as rest is generated automatically).
One more important comment is on gas basket entities and the entity hierarchy
Codecov Report
@@ Coverage Diff @@
## main #1 +/- ##
=======================================
Coverage 99.27% 99.27%
=======================================
Files 9 10 +1
Lines 685 692 +7
=======================================
+ Hits 680 687 +7
Misses 5 5
Continue to review full report at Codecov.
|
PRIMAP_entity can later be derived from gas.
I narrowed down the focus now, simply to have at least the working subset right now. It includes only gases and mixtures so far, in a separate terminology. We can then add more (e.g. gas baskets and socioeconomic entities and whatnot) to a primap terminology which builds on the gas terminology. |
Pull request
Please confirm that this pull request has done the following:
CHANGELOG.rst
addedDescription
Add a categorization for PRIMAP2 entities.