Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gas categorization. #1

Merged
merged 6 commits into from
Jul 21, 2021
Merged

Add gas categorization. #1

merged 6 commits into from
Jul 21, 2021

Conversation

mikapfl
Copy link
Member

@mikapfl mikapfl commented Mar 9, 2021

Pull request

Please confirm that this pull request has done the following:

  • Tests added
  • Documentation added (where applicable)
  • Description in CHANGELOG.rst added

Description

Add a categorization for PRIMAP2 entities.

@mikapfl
Copy link
Member Author

mikapfl commented Mar 9, 2021

So far, only emission rates derived from openscm_units are included. What else do we need? PRIMAP1 contains a lot of categories with (for me) kind of dubious codes and definitions like CO2PERC: CO2 as Percent of sth.. Also, in contrast to PRIMAP1 in PRIMAP2 we do not need to pre-define all entities, so I would propose to just standardize the common ones with a clear definition, where homogeneous naming actually is useful.

So far I understood that we definitely need:

  • emission rates of basic entities
  • emission rates of gas baskets (which baskets?)
  • socio-economic quantities (which ones?)
  • What else? Temperatures?

Copy link
Contributor

@JGuetschow JGuetschow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I made some comments on possible additional fields (probably too much work as rest is generated automatically).
One more important comment is on gas basket entities and the entity hierarchy

climate_categories/data/PRIMAP_entity.yaml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #1 (56b0737) into main (dd1a325) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main       #1   +/-   ##
=======================================
  Coverage   99.27%   99.27%           
=======================================
  Files           9       10    +1     
  Lines         685      692    +7     
=======================================
+ Hits          680      687    +7     
  Misses          5        5           
Impacted Files Coverage Δ
climate_categories/__init__.py 87.50% <100.00%> (+0.40%) ⬆️
climate_categories/tests/test_gas.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd1a325...56b0737. Read the comment docs.

@mikapfl mikapfl changed the title Add PRIMAP_entity categorization - currently, only emission rates. Add gas categorization. Jul 21, 2021
@mikapfl
Copy link
Member Author

mikapfl commented Jul 21, 2021

I narrowed down the focus now, simply to have at least the working subset right now. It includes only gases and mixtures so far, in a separate terminology. We can then add more (e.g. gas baskets and socioeconomic entities and whatnot) to a primap terminology which builds on the gas terminology.

@mikapfl mikapfl marked this pull request as ready for review July 21, 2021 15:28
@mikapfl mikapfl merged commit 130377e into pik-primap:main Jul 21, 2021
@mikapfl mikapfl deleted the primap-entity branch July 21, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants