Specify all dependencies needed to run the dwarfs example #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When following the instructions from the README, the `run_seven_dwarfs.py` study could not be run without these dependencies. For that reason, they should either be removed from the example study or be part of the dependency list.
This is only using information that is already available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When following the instructions in the README (in a a fresh venv), the following dependencies are missing when trying to run
run_seven_dwarfs.py:This PR adds them to
setup.pyand updates the basic metadata supplied there (using already available information from the GitHub repo).The former two dependencies seem to be required within
pycopancorewhile the latter two are only used from the scripts defined instudies. Thus, the latter two shouldn't actually be part ofsetup.py...Depending on how you would want to resolve this, I'm happy to add another commit which:
matplotlibandplotlyfrom the dependency list