Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add shared appearance config between all card #528

Merged
merged 27 commits into from
Jun 25, 2022
Merged

Conversation

piitaya
Copy link
Owner

@piitaya piitaya commented May 28, 2022

Description

This PR will add the possibility to hide icon, hide name, hide state, use entity picture in all cards.

Todo list :

  • merge info and layout config into appearance config
  • use appearance option in all editors
  • use appearance option in all cards
  • update documentation
  • update view examples

Related Issue

Fixes #182
Fixes #207
Fixes #365
Fixes #529

Motivation and Context

There was a lot of duplicate code between card.

How Has This Been Tested

Types of changes

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 🌎 Translation (addition or update a translation)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have tested the change locally.

@piitaya piitaya marked this pull request as ready for review June 25, 2022 19:08
@piitaya piitaya merged commit 9ce1722 into main Jun 25, 2022
@piitaya piitaya deleted the feat/shared-info branch June 25, 2022 19:08
@piitaya piitaya added the enhancement New feature or request label Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant