-
-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(media_player): add support of media player #270
Conversation
acesyde
commented
Apr 10, 2022
•
edited
Loading
edited
- Basic controls
- Dynamic icons (source)
- Volume control
Cool 🙂 |
Google translate is my friend 😂 |
We all known that 😂 |
@piitaya I think I have finished but I don't know how to change the background of the card when the |
I have try something |
Mushroom card has only one line of control. I think it's better to add a button to switch between volume controls and media controls like cover card for example for consistency. It's better to stack cards in a grid if they have the same size. For the background, it's a good idea! Maybe we can add it in avatar for now like to person card. |
Ok I will remove the background for the moment and add a switch control between buttons and volume 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool 👍 Great job !
supportsPrevious(entity) || | ||
supportsPlay(entity) || | ||
supportsPause(entity) || | ||
supportsNext(entity); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you can directly use supportsFeature
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to use the computeSupport and unitary supportsX in the buttons-control so I prefer reuse supportsX instead of rewrite again the same logic :)