Deploy fixes #189
Merged
Deploy fixes #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was facing some issues with Fabric/Crashlytics and I did want to add Firebase
This way, with the CI commiting and pushing to master, makes the CircleCI badge show as FAILED, because the lastest status of the master branch is Skiped.
I forgot this during Travis - Circle migration
Codecov Report
@@ Coverage Diff @@
## master #189 +/- ##
=========================================
Coverage ? 71.72%
=========================================
Files ? 125
Lines ? 2239
Branches ? 0
=========================================
Hits ? 1606
Misses ? 633
Partials ? 0Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.