Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation #69

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

matejklemen
Copy link
Member

Description of Changes

I saw the issue about getting the scaladocs out (#43) and I thought I'd update the docs a bit first. Mostly added single-sentence descriptions and some examples of use.

Might take a look at and update the other packages as well, should I continue in this PR or open a new PR per package?

Includes
  • Code changes
  • Tests
  • Documentation

@inejc inejc self-requested a review July 15, 2019 07:34
@inejc inejc added the enhancement New feature or request label Jul 15, 2019
@inejc
Copy link
Member

inejc commented Jul 15, 2019

@matejklemen this is super useful! There's no need for separate PRs 🙂.

@inejc
Copy link
Member

inejc commented Jul 15, 2019

And don't worry about failed circleci jobs. This is a result of secrets not being copied to forked projects 👍.

@matejklemen matejklemen changed the title Update documentation for the data package [WIP] Update documentation Jul 15, 2019
@inejc
Copy link
Member

inejc commented Jul 22, 2019

@matejklemen let me know when this is not WIP anymore and I will review it then.

@matejklemen
Copy link
Member Author

matejklemen commented Oct 15, 2019

@inejc Right, I think this is ready for a review. I didn't manage to finish the docs for all packages, but I think we should try merging this before I continue (or somebody else does) writing docs in another PR.

Mostly in hopes that we keep the documentation style consistent, but also because it's getting a bit tedious to do rebasing 😄

After rebasing, I verified/changed examples so that they are working and also I've added all the required imports to examples as I think that examples that work out of the box are much more useful than saving a few lines by skipping imports.

@matejklemen matejklemen changed the title [WIP] Update documentation Update documentation Oct 15, 2019
@inejc
Copy link
Member

inejc commented Oct 15, 2019

@matejklemen I completely agree with merging this, I will give it a quick look this week 👍.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants