Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_or_create with null values #716

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Conversation

dantownsend
Copy link
Member

Make sure that get_or_create works correctly with null values.

Fixes #715

make sure that `get_or_create` works correctly with null values
@dantownsend dantownsend added the bug Something isn't working label Dec 13, 2022
@dantownsend dantownsend changed the title 715-get-or-create-with-null get_or_create with null values Dec 13, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2022

Codecov Report

Merging #716 (0bc2de7) into master (f4e5622) will decrease coverage by 3.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #716      +/-   ##
==========================================
- Coverage   91.21%   88.10%   -3.12%     
==========================================
  Files         106      106              
  Lines        7284     7286       +2     
==========================================
- Hits         6644     6419     -225     
- Misses        640      867     +227     
Impacted Files Coverage Δ
piccolo/columns/combination.py 94.59% <100.00%> (+0.15%) ⬆️
piccolo/engine/sqlite.py 47.08% <0.00%> (-45.01%) ⬇️
piccolo/columns/defaults/base.py 80.64% <0.00%> (-19.36%) ⬇️
piccolo/query/methods/create_index.py 80.48% <0.00%> (-17.08%) ⬇️
piccolo/query/methods/indexes.py 85.71% <0.00%> (-14.29%) ⬇️
piccolo/apps/sql_shell/commands/run.py 86.11% <0.00%> (-11.12%) ⬇️
piccolo/engine/base.py 80.76% <0.00%> (-9.62%) ⬇️
piccolo/query/methods/select.py 92.21% <0.00%> (-7.38%) ⬇️
piccolo/columns/defaults/timestamp.py 87.27% <0.00%> (-7.28%) ⬇️
piccolo/query/methods/table_exists.py 92.85% <0.00%> (-7.15%) ⬇️
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dantownsend dantownsend merged commit c1a95ae into master Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UniqueViolationError when using get_or_create((.. == None) & (..))
2 participants