Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LCARS Picard Theme update for v6 #3031

Conversation

MichalSvatos
Copy link
Contributor

@MichalSvatos MichalSvatos commented May 18, 2024

What does this PR aim to accomplish?

Update for LCARS Picard theme for Pi-hole v6. Description and more screenshot available here.

Example preview
image

How does this PR accomplish the above?

  • lcars-picard.css file added
  • all settings-xxxx.lp updated for new wrapper div with ID (eg. <div id="setdns"> ... </div>
  • added condition for lcars-picard name for Theme fonts in scripts/pi-hole/lua/header.lp

EDIT: Related PR in FTL pi-hole/FTL#1971


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review.

Copy link
Contributor

github-actions bot commented Jun 1, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the stale label Jul 2, 2024
Copy link
Contributor

github-actions bot commented Jul 2, 2024

Existing merge conflicts have not been addressed. This PR is considered abandoned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant