Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete loginpage #2425

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Remove obsolete loginpage #2425

merged 1 commit into from
Nov 9, 2022

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Nov 9, 2022

What does this PR aim to accomplish?:

PR #2294 created a new login page at login.php. The old page at loginpage.phpis now obsolete.

How does this PR accomplish the above?:

Remove the page. It's not referenced anywhere.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: Christian König <[email protected]>
@yubiuser yubiuser requested review from rdwebdesign and a team November 9, 2022 22:13
@yubiuser yubiuser added the PR: Approval Required Open Pull Request, needs approval label Nov 9, 2022
Copy link
Member

@rdwebdesign rdwebdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really thought this was already gone.

Approved.

@yubiuser yubiuser merged commit 8e22142 into devel Nov 9, 2022
@yubiuser yubiuser deleted the loginpage branch November 9, 2022 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Approval Required Open Pull Request, needs approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants