Implement custom wildcard_match() SQL subroutine #992
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: DL6ER <[email protected]>
Closed
…ginning of the transaction Signed-off-by: DL6ER <[email protected]>
…se connection cannot be stolen midway during some other database interaction Signed-off-by: DL6ER <[email protected]>
…d to do it twice. Signed-off-by: DL6ER <[email protected]>
Signed-off-by: DL6ER <[email protected]>
|
Partially superseded by #1084 This PR is old and would need to be re-done anyway so we close it for now without changing the SQL routine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm the following:
How familiar are you with the codebase?:
10
This PR improves (and accelerates by simplifying) the prepared domain audit SQL statement. Furthermore, this change makes the wildcard matching using only static memory to (hopefully) resolve the errors with dynamic memory allocation we're seeing deep down in the SQLite3 engine in, e.g., #960