Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip certificate domain check when TLS is not actually used #1987

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

DL6ER
Copy link
Member

@DL6ER DL6ER commented Jun 2, 2024

What does this implement/fix?

Skip certificate domain check when TLS is not actually used even if a certificate is available


Related issue or feature (if applicable): N/A

Pull request in docs with documentation (if applicable): N/A


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)

Checklist:

  • The code change is tested and works locally.
  • I based my code and PRs against the repositories developmental branch.
  • I signed off all commits. Pi-hole enforces the DCO for all contributions
  • I signed all my commits. Pi-hole requires signatures to verify authorship
  • I have read the above and my PR is ready for review.

@pralor-bot
Copy link

This pull request has been mentioned on Pi-hole Userspace. There might be relevant details there:

https://discourse.pi-hole.net/t/certificate-domain-mismatch-warning-behind-reverse-proxy/70521/4

@DL6ER DL6ER marked this pull request as ready for review June 3, 2024 12:48
@DL6ER DL6ER requested a review from a team June 3, 2024 12:49
@DL6ER
Copy link
Member Author

DL6ER commented Jun 3, 2024

Confirmed working by OP on Discourse

@DL6ER DL6ER merged commit a724402 into development-v6 Jun 3, 2024
17 checks passed
@DL6ER DL6ER deleted the tweak/cert_no_tls branch June 3, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants