Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto-author and auto-label to github workflow #466

Merged
merged 6 commits into from
Apr 24, 2024
Merged

Add auto-author and auto-label to github workflow #466

merged 6 commits into from
Apr 24, 2024

Conversation

RayStick
Copy link
Member

@RayStick RayStick commented Apr 23, 2024

Closes #465

Proposed Changes

  • 3 new files added (auto-label.yml uses .github/labeler.yml)
  • See comment in the labeler.yml file that says -

'# removed from nigsp copy as didn't find match with phys2bids:'

  • @smoia can you check that all the relevant files are captured for phys2bids. Either list them and I will edit the file the labeler.yml file to add them, or include as a commit for me to suggest in your PR review

Change Type

  • bugfix (+0.0.1)
  • minor (+0.1.0)
  • major (+1.0.0)
  • refactoring (no version update)
  • test (no version update)
  • infrastructure (no version update)
  • documentation (no version update)
  • other

@smoia can you confirm that is the right change type label?

Checklist before review

  • I added everything I wanted to add to this PR.
  • [Code or tests only] I wrote/updated the necessary docstrings.
  • [Code or tests only] I ran and passed tests locally.
  • [Documentation only] I built the docs locally.
  • My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
  • My code respects the adopted style, especially linting conventions.
  • The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
  • I added or indicated the right labels.
  • I added information regarding the timeline of completion for this PR.
  • Please, comment on my PR while it's a draft and give me feedback on the development!

@RayStick RayStick requested a review from smoia April 23, 2024 08:12
@RayStick RayStick changed the title add workflow files Add auto-author and auto-label to github workflow Apr 23, 2024
@RayStick RayStick added the Internal Changes affect the internal API. It doesn't increase the version, but produces a changelog label Apr 23, 2024
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.18%. Comparing base (d796fe1) to head (6144adf).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #466   +/-   ##
=======================================
  Coverage   91.18%   91.18%           
=======================================
  Files           8        8           
  Lines        1010     1010           
=======================================
  Hits          921      921           
  Misses         89       89           

@RayStick
Copy link
Member Author

RayStick commented Apr 23, 2024

@smoia can you help me understand why the pre-commit test is failing? I don't understand what it is trying to do

@RayStick RayStick marked this pull request as ready for review April 23, 2024 08:37
@RayStick RayStick self-assigned this Apr 23, 2024
Copy link
Member

@smoia smoia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes but we're on the right track!!!

.github/labeler.yml Outdated Show resolved Hide resolved
.github/labeler.yml Outdated Show resolved Hide resolved
.github/labeler.yml Outdated Show resolved Hide resolved
@RayStick
Copy link
Member Author

RayStick commented Apr 24, 2024

@smoia I committed all your suggestions

I pushed one final commit to the branch because the indentation in the labeler.yml file was wrong - it is corrected now, and all the checks are passing. Please merge if you are happy to do so (please check the 'Change Type' and the labels I am using are correct, thanks)

Copy link
Member

@smoia smoia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

One done, 5 to go!

@RayStick
Copy link
Member Author

RayStick commented Apr 24, 2024

Wonderful - as main reviewer, do you merge?

One done, 5 to go!

Would that be

  • peakdet
  • phys2denoise
  • physioqc

Which other 2 repos?

@smoia
Copy link
Member

smoia commented Apr 24, 2024

physiopy.github.io and physiopy-community-guidelines.

And in fact, I forgot physiopy

@smoia
Copy link
Member

smoia commented Apr 24, 2024

Thanks @RayStick ! Merging now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Changes affect the internal API. It doesn't increase the version, but produces a changelog
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Implement auto-author-assign and auto-label workflows
2 participants