Refactor io functions related to txt file imports.

[vinferrer]

Closes nothing

Proposed Changes

• Reducing code duplicity in io.py
• merge process_acq and process_txt into process_blueprint_items
• Create extract_header_items function that gets the header and extracts interval, orig_units, orig_names and gives them to process_blueprint_items

Change Type

• bugfix (+0.0.1)
• minor (+0.1.0)
• major (+1.0.0)
• refactoring (no version update)
• test (no version update)
• infrastructure (no version update)
• documentation (no version update)
• other

Checklist before review

• I added everything I wanted to add to this PR.
• [Code or tests only] I wrote/updated the necessary docstrings.
• [Code or tests only] I ran and passed tests locally.
• [Documentation only] I built the docs locally.
• My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
• My code respects the adopted style, especially linting conventions.
• The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
• I added or indicated the right labels.

• I added information regarding the timeline of completion for this PR.

• Please, comment on my PR while it's a draft and give me feedback on the development!

[codecov]

Codecov Report

Merging #349 (2a8fb9c) into master (ff1456a) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #349      +/-   ##
==========================================
- Coverage   94.85%   94.80%   -0.06%     
==========================================
  Files           8        8              
  Lines         836      808      -28     
==========================================
- Hits          793      766      -27     
+ Misses         43       42       -1     

Impacted Files	Coverage Δ
phys2bids/io.py	99.27% <100.00%> (+0.48%)	⬆️
phys2bids/phys2bids.py	89.59% <100.00%> (ø)

[eurunuela]

I'm happy with the changes. Thank you @vinferrer !

[vinferrer]

@smoia @tsalo

[smoia]

One last thing to address (either change or reply to the suggestion), but then it's ready!

[smoia]

Let me try again.
The last moment you use interval[-1] in this function is during this if statement, to see if the value of interval[0] should be "corrected". After this if statement, interval[-1] becomes unused - from what I see, you're adding the unit s in the unit list in the hard way (coherently with your script).
For this reason, every interval[-1]='s' in this elif statement can be removed (unless you're keeping it for testing, but then please write it).
Lines 152-154 are actually superfluous. Line 152 and 154 do exactly what phys2bids.bids.bidsify_unit() does downstream, and line 153 is the same as line 156. The only change you would have to do (that is not wrong) is adding the option in line 131 for interval[-1] != 's' or interval[-1] != 'sec'. Which also makes sense for the message you're giving after in 132. It would be weird, if I know that I set up my labchart to record my sampling interval in seconds, to see that the sampling interval is not second.

You can save almost ten lines, I would do it!

[vinferrer]

Okay, now I understand. It's done

[smoia]

Last little suggestion, then it's going to be good on my side.

[smoia]

LGTM!

Great job!

[smoia]

(and yeah, we should find a way to avoid codeconv to protest every time)

[smoia]

@eurunuela if you're happy you can merge.

[eurunuela]

Thank you @vinferrer !

[smoia]

🚀 PR was released in 2.3.0 🚀