Fix

phpstan · Apr 24, 2024 · 4b66f5c · 4b66f5c
1 parent 776038d
commit 4b66f5c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/tests/Rules/Doctrine/ORM/QueryBuilderDqlRuleSlowTest.php b/tests/Rules/Doctrine/ORM/QueryBuilderDqlRuleSlowTest.php
@@ -5,6 +5,7 @@
 use PHPStan\Rules\Rule;
 use PHPStan\Testing\RuleTestCase;
 use PHPStan\Type\Doctrine\ObjectMetadataResolver;
+use const PHP_VERSION_ID;
 
 /**
  * @extends RuleTestCase<QueryBuilderDqlRule>
@@ -22,6 +23,9 @@ protected function getRule(): Rule
 
  public function testRule(): void
  {
+ if (PHP_VERSION_ID < 70300) {
+ self::markTestSkipped('For some reason PHP 7.2 cannot recover from Trying to get property value of non-object');
+ }
  $this->analyse([__DIR__ . '/data/query-builder-dql.php'], [
  [
  "QueryBuilder: [Syntax Error] line 0, col 66: Error: Expected end of string, got ')'\nDQL: SELECT e FROM PHPStan\Rules\Doctrine\ORM\MyEntity e WHERE e.id = 1)",

diff --git a/tests/Rules/Doctrine/ORM/QueryBuilderDqlRuleTest.php b/tests/Rules/Doctrine/ORM/QueryBuilderDqlRuleTest.php
@@ -5,6 +5,7 @@
 use PHPStan\Rules\Rule;
 use PHPStan\Testing\RuleTestCase;
 use PHPStan\Type\Doctrine\ObjectMetadataResolver;
+use const PHP_VERSION_ID;
 
 /**
  * @extends RuleTestCase<QueryBuilderDqlRule>
@@ -22,6 +23,10 @@ protected function getRule(): Rule
 
  public function testRule(): void
  {
+ if (PHP_VERSION_ID < 70300) {
+ self::markTestSkipped('For some reason PHP 7.2 cannot recover from Trying to get property value of non-object');
+ }
+
  $this->analyse([__DIR__ . '/data/query-builder-dql.php'], [
  [
  "QueryBuilder: [Syntax Error] line 0, col 66: Error: Expected end of string, got ')'\nDQL: SELECT e FROM PHPStan\Rules\Doctrine\ORM\MyEntity e WHERE e.id = 1)",