Duplicate types enhencements #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...Soap/Driver/ExtSoap/Metadata/Manipulators/DuplicateTypes/IntersectDuplicateTypesStrategy.php
Show resolved
Hide resolved
veewee
changed the title
drupol
reviewed
Jun 23, 2020
Co-authored-by: Pol Dellaiera <[email protected]>
drupol
reviewed
Jun 23, 2020
drupol
reviewed
Jun 23, 2020
Co-authored-by: Pol Dellaiera <[email protected]>
Co-authored-by: Pol Dellaiera <[email protected]>
|
This is great, massive improvements, can't wait to see this merged :-) |
drupol
suggested changes
Jun 24, 2020
src/Phpro/SoapClient/Soap/Driver/ExtSoap/Metadata/Detector/DuplicateTypeNamesDetector.php
Outdated
Show resolved
Hide resolved
...Soap/Driver/ExtSoap/Metadata/Manipulators/DuplicateTypes/IntersectDuplicateTypesStrategy.php
Outdated
Show resolved
Hide resolved
drupol
reviewed
Jun 24, 2020
Co-authored-by: Pol Dellaiera <[email protected]>
drupol
reviewed
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #300
I made something that allows you to manipulate the metadata before types are generated.
To try it out, I also added 2 possible strategies for fixing duplicate types.
This seems to do the trick.
Currently it matches on exact case match. This might not work if you have similar types in different cases. For example a "file" and a "File" type.
I was thinking about other strategies as well, but there is just no unique identifier like an XSD namespace. This means I could for example add an increment number, but then the code will break once items are moved inside the XSD (which is suboptimal). Another option was to make a hash of the properties, but that would also break if the type changes. Therefore, I think it is imposible to generate separate classes per type with ext-soap.
❓ Unless anyone has any better idea?
TODO: