Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RemoveEmptyNodesMiddleware: reduce till evelope body #287

Merged
merged 1 commit into from
May 29, 2020
Merged

RemoveEmptyNodesMiddleware: reduce till evelope body #287

merged 1 commit into from
May 29, 2020

Conversation

ro0NL
Copy link
Contributor

@ro0NL ro0NL commented Mar 7, 2020

fixes #286

@janvernieuwe janvernieuwe added this to the 1.1.4 milestone May 29, 2020
@janvernieuwe
Copy link
Member

janvernieuwe commented May 29, 2020 •
edited
Loading

Can you provide a test to verify that this works as expected and to prevent regressions in the future?
Update, there are some test that cover this already, i'll merge it for 1.2.0

@janvernieuwe janvernieuwe modified the milestones: 1.2.0, 1.2.1 May 29, 2020
@janvernieuwe janvernieuwe merged commit d9c2924 into phpro:master May 29, 2020
@janvernieuwe
Copy link
Member

Thanks for the contribution!

@ro0NL ro0NL deleted the patch-2 branch May 29, 2020 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

RemoveEmptyNodesMiddleware removes root node
2 participants
@ro0NL @janvernieuwe