ext/sockets: socket_accept setting fcntl's FD_CLOEXEC on unixes. #14606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
force-pushed
the
socket_accept_cloexec
branch
from
1673ee1
to
75bf3dd
Compare
mainly for scenarios when pcntl_fork/pcntl_exec are involved so when the latter is executed, we avoid unwarranted effects with the file descriptors, instead the socket will be closed on success.
devnexen
force-pushed
the
socket_accept_cloexec
branch
from
537766e
to
47f205d
Compare
nielsdos
reviewed
Jul 1, 2024
|
I know no one ; however "better safe than sorry" :) I think it does not kill doing so regardless. |
nielsdos
approved these changes
Jul 1, 2024
|
Yeah this might break some applications but worth to try it. Socket is not probably that much used so it's good first candidate to try , might be more tricky for streams though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mainly for scenarios when pcntl_fork/pcntl_exec are involved so when the latter is executed, we avoid unwarranted effects with the file descriptors, instead the socket will be closed on success.