Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP 8.4] Document new errors in XML{Reader,Writer} の翻訳 #186

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

jdkfx
Copy link
Contributor

@jdkfx jdkfx commented Nov 23, 2024

以下のPRを取り込み

php/doc-en#4123
php/doc-en#4124

4124の変更内容が軽微だったため、EN-Revisionを合わせるついでに一緒に修正を行いました。

@KentarouTakeda KentarouTakeda added the review wanted Review wanted. Please feel free to comment; anyone is welcome! label Nov 23, 2024
Copy link
Collaborator

@KentarouTakeda KentarouTakeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!

@KentarouTakeda KentarouTakeda merged commit a2d89e1 into php:master Nov 23, 2024
1 check passed
@jdkfx jdkfx deleted the xml-new-error branch November 24, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review wanted Review wanted. Please feel free to comment; anyone is welcome!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants