-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken on Laravel 5.7 #21
Comments
Looks like that was a red herring, still have reports of it not working on laravel 5.7 and tests pass when testing against 5.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Having updated the environment (#22) unit tests now reliably fail with a good idea as to what the issue is. It looks like the API for
Symfony\Component\HttpFoundation\File\UploadedFile::__construct()
has changed.This change happened about a year ago with this being the breaking change, see the difference:
Aside from the type hinting the new API does not accept the
$size
it could be that a fix is just to stop sending that to the constructor?See UnitTest result from this build below:
The text was updated successfully, but these errors were encountered: