Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Use release version of Reviewdog #116

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jsarzy
Copy link
Contributor

@jsarzy jsarzy commented Jun 21, 2022

JIRA: CI-123

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

wip
JIRA: CI-123
Comment on lines +39 to +40
FAIL("unreachable code execution") ;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[clang-format-diff] reported by reviewdog 🐶

Suggested change
FAIL("unreachable code execution") ;
FAIL("unreachable code execution");

@@ -47,7 +49,7 @@
int res;
sigjmp_buf jb;

if ((res = sigsetjmp(jb, 0)) == 0) {
if ((res = sigsetjmp(jb, 0)) == 0){

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[clang-format-diff] reported by reviewdog 🐶

Suggested change
if ((res = sigsetjmp(jb, 0)) == 0){
if ((res = sigsetjmp(jb, 0)) == 0) {

@@ -56,8 +58,7 @@
}
}

TEST(test_setjmp, sigsetjmp_savesigs_0)
{
TEST(test_setjmp, sigsetjmp_savesigs_0){

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[clang-format-diff] reported by reviewdog 🐶

Suggested change
TEST(test_setjmp, sigsetjmp_savesigs_0){
TEST(test_setjmp, sigsetjmp_savesigs_0)
{

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant