Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PATH support to rc.psh and runfile #930

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Add PATH support to rc.psh and runfile #930

merged 2 commits into from
Nov 24, 2023

Conversation

gerard5
Copy link
Contributor

@gerard5 gerard5 commented Nov 19, 2023 •
edited
Loading

Description

On targets ia32-generic, armv7a9-zynq7000, armv7a7-imx6ull add exports for the following variables:

  • PATH=/bin:/sbin:/usr/bin:/usr/sbin (supported by 'execvpe')
  • HOME=/root (supported by 'cd' command)

JIRA: RTOS-682

Updated submodule required by this change:

  • phoenix-rtos-utils bd976d0...1a7efc0 (4):

    psh: allow export and unset be used in script
    psh: implement export and unset builtins
    psh: implement printenv command
    psh/ping: add hostname resolving to IP address

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

@gerard5 gerard5 self-assigned this Nov 19, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 19, 2023 •
edited
Loading

Unit Test Results

6 002 tests  ±0   5 361 ✔️ ±0   29m 52s ⏱️ - 1m 45s
   346 suites ±0      641 💤 ±0 
       1 files   ±0          0 ❌ ±0 

Results for commit b9e7ee3. ± Comparison against base commit de6204b.

♻️ This comment has been updated with latest results.

@gerard5 gerard5 mentioned this pull request Nov 19, 2023
Merged
13 tasks
@gerard5 gerard5 marked this pull request as ready for review November 22, 2023 07:57
@gerard5 gerard5 marked this pull request as draft November 22, 2023 07:57
@gerard5 gerard5 force-pushed the gerard5/psh-environvars branch 6 times, most recently from 4f7789c to c2c2e68 Compare November 24, 2023 11:32
@gerard5
Update submodules
d9d85f7 
* phoenix-rtos-utils bd976d0...1a7efc0 (4):
  > psh: allow `export` and `unset` be used in script
  > psh: implement `export` and `unset` builtins
  > psh: implement `printenv` command
  > psh/ping: add hostname resolving to IP address

JIRA: RTOS-685
@gerard5
root-overlay: add PATH variable to psh.rc
b9e7ee3 
On targets ia32-generic*, armv7a9-zynq7000*, armv7a7-imx6ull-evk add
exports for the following variables:
* PATH=/bin:/sbin:/usr/bin:/usr/sbin (supported by 'execvpe')
* HOME=/root (supported by 'cd' command) variables

JIRA: RTOS-682
@gerard5 gerard5 marked this pull request as ready for review November 24, 2023 13:17
damianloew
damianloew reviewed Nov 24, 2023
View reviewed changes
Copy link
Contributor

@damianloew damianloew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest updating submodules in the separate PR and then adding only changes in rc.psh there. Above that, looks good to me

agkaminski
agkaminski approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@agkaminski agkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damianloew
Copy link
Contributor

I'd suggest updating submodules in the separate PR and then adding only changes in rc.psh there. Above that, looks good to me

I see that it was done this way before, so looks fine

@gerard5 gerard5 merged commit 4938157 into master Nov 24, 2023
30 checks passed
@gerard5 gerard5 deleted the gerard5/psh-environvars branch November 24, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agkaminski agkaminski agkaminski approved these changes

@damianloew damianloew damianloew approved these changes

Assignees

@gerard5 gerard5

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gerard5 @damianloew @agkaminski