Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

targets: fix regex matching syspage sections on riscv64 #820

Merged
merged 2 commits into from
Sep 6, 2023
Merged

targets: fix regex matching syspage sections on riscv64 #820

merged 2 commits into from
Sep 6, 2023

Conversation

gerard5
Copy link
Contributor

@gerard5 gerard5 commented Sep 6, 2023 •
edited
Loading

Description

The change fixes the regex incorrectly matching multiple occurrences of the section names *_start (should match once, _start exactly). The fix is to add a blank match before the section names.

With build.sh use host component which is required to build syspagen (CI fails because of no host component in default buld params?).

Update: This PR adds host to CI #821

JIRA: RTOS-592

Types of changes

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: riscv64-generic-qemu, riscv64-generic-spike.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@gerard5 gerard5 self-assigned this Sep 6, 2023
@gerard5 gerard5 mentioned this pull request Sep 6, 2023
Closed
@gerard5 gerard5 force-pushed the gerard5/RTOS-592 branch 2 times, most recently from 1c7f319 to fd1bbe4 Compare September 6, 2023 08:53
@gerard5
targets: fix regex matching syspage sections on riscv64
bd59e09 
The change fixes the regex incorrectly matching multiple
occurrences of the section names `*_start` (should match
once, `_start` exactly). The fix is to add a blank match
before the section names.

JIRA: RTOS-592
@gerard5
scripts/riscv64-generic: add drive format=raw
e24cb90 
Avoid annoying warning message regarding the `raw` image format.

JIRA: RTOS-592
@gerard5 gerard5 marked this pull request as ready for review September 6, 2023 10:10
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Unit Test Results

5 490 tests  ±0   4 894 ✔️ ±0   23m 11s ⏱️ +42s
   283 suites ±0      596 💤 ±0 
       1 files   ±0          0 ❌ ±0 

Results for commit e24cb90. ± Comparison against base commit 05bc667.

@gerard5 gerard5 merged commit 790a59c into master Sep 6, 2023
29 checks passed
@gerard5 gerard5 deleted the gerard5/RTOS-592 branch September 6, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalajcie nalajcie nalajcie approved these changes

Assignees

@gerard5 gerard5

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to find the RISC-V BIOS (looking for phoenix.osbi)
2 participants
@gerard5 @nalajcie