Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test of cpptest #535

Draft
wants to merge 1 commit into
base: jsarzy/cpptest
Choose a base branch
from
Draft

test of cpptest #535

wants to merge 1 commit into from

Conversation

jsarzy
Copy link
Contributor

@jsarzy jsarzy commented Oct 21, 2022

Do not merge.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@jsarzy jsarzy force-pushed the jsarzy/cpptest-test branch 6 times, most recently from 611e575 to 8b71837 Compare October 24, 2022 12:36
github-actions[bot]
github-actions bot reviewed Oct 24, 2022
View reviewed changes
_user/hello/main.c

int main(void)
{
printf("Hello World!!\n");

add(1, 2);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [cpptestcli] <MISRAC2012-RULE_17_7-a> reported by reviewdog 🐶
Unused function's "add" return value

_user/hello/main.c
@@ -15,10 +15,18 @@

#include <stdio.h>

int add(int a, int b) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [cpptestcli] <MISRAC2012-DIR_4_6-b> reported by reviewdog 🐶
The basic numerical type 'int' should not be used

_user/hello/main.c
@@ -15,10 +15,18 @@

#include <stdio.h>

int add(int a, int b) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [cpptestcli] <MISRAC2012-DIR_4_6-b> reported by reviewdog 🐶
The basic numerical type 'int' should not be used

_user/hello/main.c
@@ -15,10 +15,18 @@

#include <stdio.h>

int add(int a, int b) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [cpptestcli] <MISRAC2012-RULE_8_4-a> reported by reviewdog 🐶
Prototype of function 'add' does not precede function definition

_user/hello/main.c
@@ -15,10 +15,18 @@

#include <stdio.h>

int add(int a, int b) {
int c = a + b;
printf("Add: %d\n", c);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [cpptestcli] <MISRAC2012-RULE_21_6-a> reported by reviewdog 🐶
Usage of 'printf' function is not allowed

_user/hello/main.c
@@ -15,10 +15,18 @@

#include <stdio.h>

int add(int a, int b) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [cpptestcli] <MISRAC2012-RULE_8_7-a> reported by reviewdog 🐶
The function 'add' is referenced only in the translation unit where it is defined

_user/hello/main.c
@@ -15,10 +15,18 @@

#include <stdio.h>

int add(int a, int b) {
int c = a + b;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [cpptestcli] <MISRAC2012-DIR_4_6-b> reported by reviewdog 🐶
The basic numerical type 'int' should not be used

_user/hello/main.c
@@ -15,10 +15,18 @@

#include <stdio.h>

int add(int a, int b) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [cpptestcli] <MISRAC2012-DIR_4_6-b> reported by reviewdog 🐶
The basic numerical type 'int' should not be used

_user/hello/main.c
@@ -15,10 +15,18 @@

#include <stdio.h>

int add(int a, int b) {
int c = a + b;
printf("Add: %d\n", c);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [cpptestcli] <MISRAC2012-RULE_17_7-a> reported by reviewdog 🐶
Unused function's "printf" return value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jsarzy