Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build.project: allow to run b_build_project function from specific target build file #36

Merged
merged 2 commits into from
Nov 20, 2020
Merged

build.project: allow to run b_build_project function from specific target build file #36

merged 2 commits into from
Nov 20, 2020

Conversation

HBuczynski
Copy link
Contributor

nalajcie
nalajcie requested changes Nov 20, 2020
View reviewed changes
Copy link
Member

@nalajcie nalajcie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the changes are good, I would simplify the logic for includeing the project-specific file.

build.project Show resolved Hide resolved
build.project Outdated Show resolved Hide resolved
nalajcie
nalajcie reviewed Nov 20, 2020
View reviewed changes
build.project Show resolved Hide resolved
build.project Outdated Show resolved Hide resolved
nalajcie
nalajcie reviewed Nov 20, 2020
View reviewed changes
build.project Outdated Show resolved Hide resolved
@nalajcie nalajcie merged commit 54eddd8 into phoenix-rtos:master Nov 20, 2020
@HBuczynski HBuczynski deleted the build branch February 1, 2021 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nalajcie nalajcie nalajcie approved these changes

@agkaminski agkaminski Awaiting requested review from agkaminski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HBuczynski @nalajcie