Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_targets: Add 'blob' command #1096

Merged
merged 1 commit into from
Jun 18, 2024
Merged

_targets: Add 'blob' command #1096

merged 1 commit into from
Jun 18, 2024

Conversation

Darchiv
Copy link
Member

@Darchiv Darchiv commented Jun 14, 2024

When supplying paths for app and blob commands:

  • relative path path resolves to _build/arch/prog.stripped/path
  • absolute path path resolves to _fs/arch/root/path

JIRA: NIL-571

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

agkaminski
agkaminski previously approved these changes Jun 14, 2024
Copy link

github-actions bot commented Jun 14, 2024

Unit Test Results

7 460 tests  ±0   6 745 ✅ ±0   38m 1s ⏱️ +5s
  420 suites ±0     715 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 2c6637a. ± Comparison against base commit 5011be2.

♻️ This comment has been updated with latest results.

_targets/build.common Outdated Show resolved Hide resolved
When supplying paths for `app` and `blob` commands:
- relative path <path> resolves to _build/<arch>/prog.stripped/<path>
- absolute path <path> resolves to _fs/<arch>/root/<path>

JIRA: NIL-571
@Darchiv Darchiv merged commit ac1f761 into master Jun 18, 2024
30 checks passed
@Darchiv Darchiv deleted the blob_cmd branch June 18, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants