Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_targets: configure building coremark port #1089

Closed
wants to merge 2 commits into from

Conversation

lukileczo
Copy link
Contributor

@lukileczo lukileczo commented May 28, 2024

JIRA: RTOS-832

Description

Add coremark port.

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@lukileczo lukileczo requested a review from agkaminski May 28, 2024 08:55
* phoenix-rtos-ports 8f30667...be677de (1):
  > add coremark port

  JIRA: RTOS-832
@nalajcie
Copy link
Member

I don't think enabling new ports by default in target files is the way to go (eg. right now You've added new binary in DTR project making rootfs/update pkg bigger than before - I think this was not intended?).

Maybe we should enable working ports in our reference projects (so in _project subdir?)

@lukileczo lukileczo closed this May 28, 2024
@lukileczo lukileczo deleted the lukileczo/coremark branch May 28, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants