Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toolchain: fix building toolchain #1061

Closed
wants to merge 2 commits into from
Closed

Conversation

nalajcie
Copy link
Member

@nalajcie nalajcie commented Apr 25, 2024

Description

  • toolchain: skip checking if build env is sane
  • makes: make build env sanity checks optional
    Needed for building toolchain (uses install-headers directly without build.sh
    entrypoint).

Motivation and Context

JIRA: CI-453

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (refactoring, style fixes, git/CI config, submodule management, no code logic changes)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: arm-phoenix

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@nalajcie
Copy link
Member Author

PR from pseudo-release test branch seems to be a bad idea after all.

@nalajcie nalajcie closed this Apr 25, 2024
@nalajcie nalajcie deleted the release/_nalajcie_ci_check branch April 25, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant