Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST BRANCH [DO NOT MERGE] #1052

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

TEST BRANCH [DO NOT MERGE] #1052

wants to merge 1 commit into from

Conversation

adamdebek
Copy link
Contributor

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@adamdebek adamdebek marked this pull request as draft April 8, 2024 17:42
Copy link

github-actions bot commented Apr 8, 2024

Unit Test Results

6 580 tests   5 951 ✅  34m 39s ⏱️
  368 suites    626 💤
    1 files        3 ❌

For more details on these failures, see this check.

Results for commit 490e4a8.

♻️ This comment has been updated with latest results.

@adamdebek adamdebek force-pushed the adamdebek/TCP_TEST branch 4 times, most recently from 71a6839 to 87af22a Compare April 24, 2024 16:38
@adamdebek adamdebek force-pushed the adamdebek/TCP_TEST branch 8 times, most recently from 84dd8ae to 235aab6 Compare June 13, 2024 14:02
Comment on lines +99 to +100
#define LWIP_DEBUG 1
#define TCP_DEBUG LWIP_DBG_ON

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[clang-format-pr] reported by reviewdog 🐶
suggested fix

Suggested change
#define LWIP_DEBUG 1
#define TCP_DEBUG LWIP_DBG_ON
#define LWIP_DEBUG 1
#define TCP_DEBUG LWIP_DBG_ON

@adamdebek adamdebek force-pushed the adamdebek/TCP_TEST branch 3 times, most recently from 1646ac3 to 490e4a8 Compare June 13, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant