Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RTLD]Adapt build env to shared libs #177

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

[RTLD]Adapt build env to shared libs #177

wants to merge 6 commits into from

Conversation

badochov
Copy link
Contributor

@badochov badochov commented Jan 30, 2024 •
edited

JIRA: RTOS-664

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

@badochov badochov changed the title Adapt build env to shared libs [RTLD]Adapt build env to shared libs Jan 30, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 30, 2024 •
edited

Unit Test Results

7 700 tests  ±0   6 985 ✅ ±0   37m 6s ⏱️ -42s
  436 suites ±0     715 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit b74f360. ± Comparison against base commit f995fe1.

♻️ This comment has been updated with latest results.

@badochov badochov mentioned this pull request Jan 30, 2024
Draft
13 tasks
@badochov badochov force-pushed the badochov/dynamic-linker branch 3 times, most recently from 55e17e4 to d0dcec7 Compare February 1, 2024 01:29
github-actions[bot]
github-actions bot reviewed Aug 5, 2024
View reviewed changes
makes/shared-lib.mk Outdated
$(PREFIX_ROOTFS)$(LOCAL_INSTALL_PATH)/$(NAME).so: $(PREFIX_SO)$(NAME).so
$(INSTALL_FS)

# necessary for NAME variable to be correctly set in recepies
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[codespell] reported by reviewdog 🐶
recepies ==> recipes, recopies

@badochov badochov force-pushed the badochov/dynamic-linker branch 3 times, most recently from 563921b to 24c146c Compare August 21, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions github-actions left review comments

@agkaminski agkaminski Awaiting requested review from agkaminski

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@badochov