Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TVOS] Adds tvOS compatibility. #31

Merged
merged 4 commits into from
Oct 14, 2015
Merged

Conversation

darionco
Copy link
Contributor

This PR adds compatibility for tvOS by configuring the project files and adding a new script: maketvos.py which builds JavaScriptCore-tvOS.framework that can be used in tvOS projects.

@phoboslab
Copy link
Owner

Awesome!

Can you explain why this needs to be a different .framework though? Couldn't it be merged as just another slice in the same lib?

@darionco
Copy link
Contributor Author

I have not tried that, I just followed Apple's examples in which they actually have different frameworks for iOS and tvOS. It made sense since tvOS is an ARM64 platform, the same as some iOS devices.

@phoboslab
Copy link
Owner

So, the question is, what actually makes the lib that is built for arm64 tvOS different from the one that's built for arm64 iOS? Why is it a different binary at all? Maybe it's just a flag somewhere in the lib that marks it as "tvOS compatible"?

I'll try to build the lib with your maketvos.py and then see if I can stick into the lib for iOS & Simulator.

@phoboslab
Copy link
Owner

> lipo -create JavaScriptCore-ios JavaScriptCore-tvos -output JavaScriptCore-universal.lib
fatal error: lipo JavaScriptCore-ios and JavaScriptCore-tvos have the same architectures (x86_64) and can't be in the same fat output file

Well, I guess we have to build two frameworks after all.

Thanks!

phoboslab added a commit that referenced this pull request Oct 14, 2015
[TVOS] Adds tvOS compatibility.
@phoboslab phoboslab merged commit e17c376 into phoboslab:master Oct 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants