Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host Card Emulation (HCE) App with IsoApplet #5

Closed
wants to merge 1 commit into from

Conversation

frankmorgner
Copy link

I created a simple Host Card Emulation (HCE) App for Android which integrates https://github.com/licel/jcardsim to emulate the IsoApplet (among others).

In order to make the IsoApplet compatible with jCardSim I had to ignore an error which is probably also usefull in other situations.

@philipWendland
Copy link
Owner

Hi,
thanks for this PR.

The ObjectDeletion-call in the constructor was there to prevent the installation of the applet on smartcards which do not support the RequestObjectDeletion mechanism. I.e. the exception was wanted to be thrown. In fact, this mechanism only frees garbage in the current applets context, and there is none at this point.

But as

  1. I have yet to see a JC 2.2.2 card that does not implement this,
  2. Deletion of files is fairly uncommon,
  3. Maybe some unreferenced files are better than an unsupported card
  4. and there are use cases in simulators which have normal Java Garbage collection but do not "implement" the RequestObjectDeletion mechanism
    I think it is valid to loosen this up.

Does 2b44129 (Note that it is in this branch) solve the issue for you as well? If so, I think it can be integrated in the master branch.

@frankmorgner
Copy link
Author

yes, with 2b44129 it indeed works as expected. I fully agree with your arguments for not depending on RequestObjectDeletion

@philipWendland
Copy link
Owner

Thank you for re-testing.

Solved with 2b44129 in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants