Support jcardsim and J3H081 #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcardsim's PersistentSimulatorRuntime cannot persist Signature objects, so make those temporary and not part of the class object. Additionally, allow skipping checks for RSA4096 and for RSA PSS, as even just testing them can prevent applet installation on certain cards (J3H081).
|
The changes to support jcardsim PersistentSimulatorRuntime may not be a good call, I'm not sure - since Signature objects have to be deleted by the card runtime, and if it doesn't support it it will quickly break. |
I am not sure, but I think I agree. Maybe there is another way? If I am not mistaken, the J3H081 is an older card that seems to target JavaCard 3.0.1 classic. Please use the legacy version of IsoApplet as indicated in the readme. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jcardsim's PersistentSimulatorRuntime cannot persist Signature objects, so make those temporary and not part of the class object. Additionally, allow skipping checks for RSA4096 and for RSA PSS, as even just testing them can prevent applet installation on certain cards (J3H081).