Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle non-existant categories and urls #241

Merged
merged 1 commit into from
Feb 3, 2024
Merged

Handle non-existant categories and urls #241

merged 1 commit into from
Feb 3, 2024

Conversation

ticua07
Copy link
Contributor

@ticua07 ticua07 commented Feb 3, 2024

Handle urls that don't exist:
image
This happens when accessing https://svgl.app/doesnotexist and because there isn't an +error.svelte present, a default message is shown instead.

image
Also, there isn't any validation that the category exists, so when changing the url to an invalid category no logos will appear

Copy link

vercel bot commented Feb 3, 2024

Someone is attempting to deploy a commit to a Personal Account owned by @pheralb on Vercel.

@pheralb first needs to authorize it.

@ticua07
Copy link
Contributor Author

ticua07 commented Feb 3, 2024

This is my first pull request ever, any suggestions are appreciated!

@ticua07 ticua07 changed the title ⚙ Handle non-existant categories and urls Handle non-existant categories and urls Feb 3, 2024
@pheralb
Copy link
Owner

pheralb commented Feb 3, 2024

Thanks for contributing 🥹🚀

@pheralb pheralb merged commit 72ff8b2 into pheralb:main Feb 3, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants