Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMP specification 1.2.0: Check ServiceActivationDate/ServiceExpirationDate #38

Closed
Florianisme opened this issue Feb 7, 2022 · 3 comments

Comments

@Florianisme
Copy link

As far as I am aware, the fields ServiceActivationDate and ServiceExpirationDate returned in the response from the SMP when querying an endpoint are ignored as of now.
As of version 1.2.0 of the SMP it was clarified that they should be checked for validity and the connection to that endpoint should be refused when they are not valid yet/anymore.

I guess it should be a check in the SMPClientReadOnly class in the getEndpoint() Method. I can try to add it myself if you have not planned anything yet.

@Florianisme
Copy link
Author

Florianisme commented Feb 7, 2022

Oops, wrong repository. It belongs in https://github.com/phax/peppol-commons
Can you move the issue?

@ghost ghost assigned phax Feb 7, 2022
@phax phax transferred this issue from phax/phase4 Feb 7, 2022
@phax
Copy link
Owner

phax commented Feb 7, 2022

As this change is only due at May 1st, 2022 I have some time to get this done.
Key point will be, that the LocalDateTime und question needs to be added to the API.
It will be done soon

@phax
Copy link
Owner

phax commented Mar 28, 2022

Part of the 8.7.3 release

@phax phax closed this as completed Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants