Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a forward proxy with username/password to be specified on a lookup call #13

Closed
dhixon opened this issue May 4, 2017 · 4 comments
Assignees

Comments

@dhixon
Copy link

dhixon commented May 4, 2017

In SoftLayer (and other cloud environments I suspect), all our outbound connections goes through a forward proxy, so this look up being an outbound call, needs to go thru that fwd proxy. Furthermore, in our case we read the proxy values from a DB at runtime. Consequently, we need a way to pass the proxy host, port, username and password to the smp-client on the lookup call which would then be used to make the http connection.

Finally, we have multiple environments with different requirements. Some are internal only and don't use a proxy, some use a proxy, but don't require userid and password, and some require the proxy and the userid/password. It would be nice if the lookup ignores any parameters that have a null value, for example the proxy host and port could be present with some values, whereas username and password might not there there..so it should just use the proxy host and port in that case.

@phax phax self-assigned this May 4, 2017
@phax
Copy link
Owner

phax commented May 4, 2017

Reminder to myself: see http:https://stackoverflow.com/questions/6962047/apache-httpclient-4-1-proxy-authentication as an example on how it could be done

@phax
Copy link
Owner

phax commented May 10, 2017

It was implemented, but I cannot test it....

@dhixon
Copy link
Author

dhixon commented May 10, 2017 via email

@phax
Copy link
Owner

phax commented May 15, 2017

I assume it's working - just let me know if not :)

@phax phax closed this as completed May 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants