Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closes #1839 dummy function created #1866

Closed
wants to merge 3 commits into from
Closed

Conversation

PavloChaika
Copy link
Collaborator

@PavloChaika PavloChaika commented Apr 12, 2023

Thank you for your Pull Request! We have developed this task checklist from the Development Process Guide to help with the final steps of the process. Completing the below tasks helps to ensure our reviewers can maximize their time on your code as well as making sure the admiral codebase remains robust and consistent.

Please check off each taskbox as an acknowledgment that you completed the task or check off that it is not relevant to your Pull Request. This checklist is part of the Github Action workflows and the Pull Request will not be merged into the devel branch until you have checked off each task.

  • Place Closes #<insert_issue_number> into the beginning of your Pull Request Title (Use Edit button in top-right if you need to update)
  • Code is formatted according to the tidyverse style guide. Run styler::style_file() to style R and Rmd files
  • Updated relevant unit tests or have written new unit tests, which should consider realistic data scenarios and edge cases, e.g. empty datasets, errors, boundary cases etc. - See Unit Test Guide
  • If you removed/replaced any function and/or function parameters, did you fully follow the deprecation guidance?
  • Update to all relevant roxygen headers and examples, including keywords and families. Refer to the categorization of functions to tag appropriate keyword/family.
  • Run devtools::document() so all .Rd files in the man folder and the NAMESPACE file in the project root are updated appropriately
  • Address any updates needed for vignettes and/or templates
  • Update NEWS.md if the changes pertain to a user-facing function (i.e. it has an @export tag) or documentation aimed at users (rather than developers)
  • Build admiral site pkgdown::build_site() and check that all affected examples are displayed correctly and that all new functions occur on the "Reference" page.
  • Address or fix all lintr warnings and errors - lintr::lint_package()
  • Run R CMD check locally and address all errors and warnings - devtools::check()
  • Link the issue in the Development Section on the right hand side.
  • Address all merge conflicts and resolve appropriately
  • Pat yourself on the back for a job well done! Much love to your accomplishment!

@PavloChaika PavloChaika linked an issue Apr 12, 2023 that may be closed by this pull request
@PavloChaika PavloChaika requested a review from bms63 April 12, 2023 19:29
@bms63
Copy link
Collaborator

bms63 commented Apr 12, 2023

This is awesome!!! use devtools::document() to get your function to the NAMESPACE and render the documeantion, .Rd files. This will fix a lot of the issues in the CI checks.

Also run styler::style_file() on the files your created for the styler check.

@robertdevine
Copy link
Collaborator

Thank you, @PavloChaika and @bms63. In the Development Process Guide, there is a dead link [i.e. 404 Not Found] at the admiral contribution model link near the top of the Guide.

Love the checklist compiled here!

@github-actions
Copy link

github-actions bot commented Apr 17, 2023

Code Coverage

Package Line Rate Health
admiral 98%
Summary 98% (4134 / 4213)

@bms63
Copy link
Collaborator

bms63 commented Apr 20, 2023

You almost got them all!! USe spelling::update_wordlist() to fix the spelling failing check. The links might just be a timeout issue not really sure yet on that one.

@bms63
Copy link
Collaborator

bms63 commented May 5, 2023

@PavloChaika did you have anymore questions? If not, then we can close out this PR

@PavloChaika
Copy link
Collaborator Author

@bms63 no more questions

@bms63 bms63 closed this May 5, 2023
@PavloChaika PavloChaika deleted the 1839_dummy@devel branch May 21, 2023 10:34
@bms63 bms63 removed a link to an issue May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants