-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation: derive_locf_records lose LOCF records. only 12 records there without any LOCF action #2461
Comments
Thank you @WangLaoK for the feedback! @pharmaverse/admiral is there a way to display more of the rows in the examples? |
Would |
Not sure if we can put LOCF record in the first 12 rows. please check the example in this link. https://pharmaverse.github.io/admiral/reference/derive_locf_records.html |
{admiral} doesn't sort the output datasets usually. Maybe in the example we would need to combine |
I would change the subject ids such that the second subject is displayed first and sort the output dataset by |
Hi @WangLaoK how come you closed this issue? I don't think we actioned it yet. I'm reopening it for now. |
Hi @manciniedoardo , sorry for the actions. I thought this query had been aware and solved from a new release. I will not close issues next time. hope this is fine for you,. Regards, |
@manciniedoardo … what do I need to do finish this? #2461. Thx (also reading a lot re: pharmaverse) |
Will review, thanks for the reminder. |
I think now done. And it is better than mine! Still learning |
Before I push again to #2475, I want to check this is right path: (intermediate variable Now:As written, the example code must display all records to see
ProposedHowever, If I understand bundfussr's ... suggestion correctly, better to display USUBJID column first, followed by PARAMCD, AVISIT. But this still requires printing all rows to see LOCF*, as follows:
|
@jimrothstein the arrange call looks right, but I think no need to use Please feel free to make a PR and tag us for review - it's not a problem at all if then we request some changes, that's what the review is for! |
@manciniedoardo This
I suspect you meant tinkering with the original Unrelated, I hopeCould not |
Please select a category the issue is focused on?
Function Documentation
Let us know where something needs a refresh or put your idea here!
#> # A tibble: 22 × 8
#> STUDYID USUBJID PARAMCD PARAMN AVAL AVISITN AVISIT DTYPE
#>
#> 1 CDISC01 01-701-1015 DIABP 2 51 0 BASELINE NA
#> 2 CDISC01 01-701-1015 DIABP 2 50 2 WEEK 2 NA
#> 3 CDISC01 01-701-1015 DIABP 2 51 4 WEEK 4 NA
#> 4 CDISC01 01-701-1015 DIABP 2 50 6 WEEK 6 NA
#> 5 CDISC01 01-701-1015 PULSE 1 61 0 BASELINE NA
#> 6 CDISC01 01-701-1015 PULSE 1 60 6 WEEK 6 NA
#> 7 CDISC01 01-701-1015 SYSBP 3 121 0 BASELINE NA
#> 8 CDISC01 01-701-1015 SYSBP 3 121 2 WEEK 2 NA
#> 9 CDISC01 01-701-1015 SYSBP 3 121 4 WEEK 4 NA
#> 10 CDISC01 01-701-1015 SYSBP 3 121 6 WEEK 6 NA
#> # ℹ 12 more rows
Should have 12 more rows below, then user can see the LCOF creation there.
The text was updated successfully, but these errors were encountered: