Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor PHP temp directory config #6

Merged
merged 1 commit into from
Dec 29, 2019
Merged

Honor PHP temp directory config #6

merged 1 commit into from
Dec 29, 2019

Conversation

mvorisek
Copy link
Contributor

Fixed /tmp directory can be outside open_basedir scope. This fixes it using PHP config which is expected to be correct (and sys_get_temp_dir will return /tmp by default if no config is set).

@mvorisek
Copy link
Contributor Author

@sebastianbergmann Can you merge?

@theseer
Copy link
Member

theseer commented Dec 11, 2019

While using sys_get_temp_dir probably makes sense and I'm inclined to merge this PR for that reason alone, I fail to see where an open_basedir restriction might be an issue? The PR addresses a test. Tests are run on CLI. I don't know why any sane admin would restrict access to /tmp for a CLI process...?

In what scenario would that be plausible?

@mvorisek
Copy link
Contributor Author

@theseer

While using sys_get_temp_dir probably makes sense and I'm inclined to merge this PR for that reason alone, I fail to see where an open_basedir restriction might be an issue? The PR addresses a test. Tests are run on CLI. I don't know why any sane admin would restrict access to /tmp for a CLI process...?

In what scenario would that be plausible?

Hi, for example in our enviroment we have PHP temp dir set to some /tmp/xxx subdir and only this dir set in open_basedir.

@theseer
Copy link
Member

theseer commented Dec 29, 2019

Fair enough.

@theseer theseer merged commit 3d94e3b into phar-io:master Dec 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants