Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use implicitly nullable parameters #35

Merged
merged 1 commit into from
Mar 3, 2024
Merged

Do not use implicitly nullable parameters #35

merged 1 commit into from
Mar 3, 2024

Conversation

sebastianbergmann
Copy link
Member

This pull request only contains the necessary code change for sebastianbergmann/phpunit#5719, it does not update the ChangeLog or prepare a release in any other way. This is because I ran into the following problems.

The ChangeLog that there is a 2.1.0 release. But there is no 2.1.0 tag, the latest tag is 2.0.3.

Since the release of 2.0.3, support for PHP 7.2 was dropped. For PHPUnit 8.5, we need a version of phar-io/manifest that supports PHP 7.2.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.83%. Comparing base (6772927) to head (38cb02c).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master      #35   +/-   ##
=========================================
  Coverage     99.83%   99.83%           
  Complexity      195      195           
=========================================
  Files            40       40           
  Lines           589      589           
=========================================
  Hits            588      588           
  Misses            1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@theseer theseer merged commit e1da028 into phar-io:master Mar 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants