Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Set up phpunit as tool #22

Merged
merged 1 commit into from
Feb 21, 2022
Merged

Conversation

localheinz
Copy link
Contributor

@localheinz localheinz commented Feb 21, 2022

This pull request

  • sets up phpunit:8.5 as tool instead of installing it with phive

@localheinz localheinz force-pushed the fix/phive branch 11 times, most recently from 8773c11 to ec0a018 Compare February 21, 2022 14:11
@localheinz localheinz closed this Feb 21, 2022
@localheinz localheinz deleted the fix/phive branch February 21, 2022 14:13
@theseer
Copy link
Member

theseer commented Feb 21, 2022

?

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@localheinz localheinz restored the fix/phive branch February 21, 2022 14:26
@localheinz localheinz reopened this Feb 21, 2022
@localheinz localheinz force-pushed the fix/phive branch 6 times, most recently from 4cf2b6c to 52c834c Compare February 21, 2022 14:40
@localheinz localheinz marked this pull request as ready for review February 21, 2022 14:42
@localheinz localheinz changed the title Fix: Installation of dependencies with phive on Windows Fix: Set up phpunit as tool Feb 21, 2022
@localheinz localheinz force-pushed the fix/phive branch 3 times, most recently from 5f95620 to 190c432 Compare February 21, 2022 14:59
@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2022

Codecov Report

Merging #22 (11da72a) into master (b0732e3) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #22      +/-   ##
============================================
- Coverage     99.82%   99.82%   -0.01%     
  Complexity      195      195              
============================================
  Files            40       40              
  Lines           578      571       -7     
============================================
- Hits            577      570       -7     
  Misses            1        1              

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8895d99...11da72a. Read the comment docs.

Comment on lines +65 to +66
env:
COMPOSER_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
Copy link
Contributor Author

@localheinz localheinz Feb 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this helps, @theseer!

For reference, see https://github.com/shivammathur/setup-php:

CleanShot 2022-02-21 at 17 24 13@2x

@theseer theseer merged commit 36d8a21 into phar-io:master Feb 21, 2022
@localheinz localheinz deleted the fix/phive branch February 21, 2022 20:19
@localheinz
Copy link
Contributor Author

Thank you, @theseer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants