fix: support insert ... on conflict...update for reWriteBatchedInserts=true #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s=true pgjdbc will avoid rewriting the query if a bind is identified after values(...) That is ON CONFLICT... DO update set x=? is NOT rewrite-compatible, and update set x='default' is rewrite-compatible "reported" here: https://stackoverflow.com/questions/47664889/jdbc-batch-operations-understanding/48349524?noredirect=1#comment84691562_48349524
Codecov Report
@@ Coverage Diff @@
## master #1130 +/- ##
============================================
+ Coverage 67.25% 67.28% +0.03%
- Complexity 3673 3680 +7
============================================
Files 170 170
Lines 15640 15643 +3
Branches 2531 2533 +2
============================================
+ Hits 10519 10526 +7
+ Misses 3932 3928 -4
Partials 1189 1189 |
Daenyth
reviewed
Feb 23, 2018
| ps.setString(2, "53"); | ||
| ps.addBatch(); | ||
| int[] actual = ps.executeBatch(); | ||
| BatchExecuteTest.assertSimpleInsertBatch(2, actual); |
There was a problem hiding this comment.
Is there a way to test that it executed only a single statement? The fact that this asserts the same as the above test makes me feel uncertain.
There was a problem hiding this comment.
|
I believe this fixes #783 |
|
Is there anything I could do to help speed this branch along? |
vlsi
changed the title
|
I notice there's no tests in here that cover having a WHERE clause in the ON CONFLICT section. I haven't had time to test if it works; do you think it would? |
|
@Daenyth , I think it would, however more tests would definitely make sense there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pgjdbc will avoid rewriting the query if a bind is identified after values(...)
That is ON CONFLICT... DO update set x=? is NOT rewrite-compatible, and update set x='default' is rewrite-compatible
"reported" here: https://stackoverflow.com/questions/47664889/jdbc-batch-operations-understanding/48349524?noredirect=1#comment84691562_48349524