Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong null check on PGobject #2411

Closed
gustavovnicius opened this issue Jan 19, 2022 · 2 comments
Closed

Wrong null check on PGobject #2411

gustavovnicius opened this issue Jan 19, 2022 · 2 comments

Comments

@gustavovnicius
Copy link

https://github.com/pgjdbc/pgjdbc/blob/f81244faf90c3203b1b50cbfa0f9f3ca8c923c0c/pgjdbc/src/main/java/org/postgresql/util/PGobject.java#L75..L77

Wrong null check for PGobject. It should be getValue() == null or isNull(value)
@davecramer
Copy link
Member

Thanks, can't believe that is in there.

davecramer added a commit to davecramer/pgjdbc that referenced this issue Jan 19, 2022
@davecramer
fix: PgObject isNull() was reporting the opposite fixes Issue pgjdbc#…
731a0ad 
…2411
davecramer added a commit that referenced this issue Jan 19, 2022
@davecramer
fix: PgObject isNull() was reporting the opposite fixes Issue #2411 (#…
4d494bf 
…2414)
@davecramer
Copy link
Member

fixed with PR #2414

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davecramer @gustavovnicius