Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

normalize path for SVF Downloader #80

Merged
merged 1 commit into from
May 7, 2024

Conversation

lucaschadwicklam97
Copy link

When using the downloader via APS VS Code extension, the downloader downloads corrupt files with filenames that match objects_*.json.gz. From a manifest.json file retrieved from unzipping contents from the .svf file, the asset URI's for those objects include \..\ in the path, which, when normalized, will go up the directory, and thereby download the correct contents for the file.

I've tested this with Python and the files outputted after the normalizing the path are valid JSON and no longer corrupt.

@lucaschadwicklam97
Copy link
Author

hi @petrbroz, would you be able to review this? let me know if you need anything else from me

@petrbroz
Copy link
Owner

petrbroz commented May 7, 2024

Thanks @lucaschadwicklam97, good catch! I'm surprised I haven't run into this issue before (the objects_*.json.gz would always download fine for me), but this code change looks like it would help in these kinds of scenarios.

@petrbroz petrbroz merged commit fcecb3e into petrbroz:develop May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants