Fix race condition described in issue #1417 #1449
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@benjamingr Can it be merged or rejected? It's 17 months old already. |
|
Yeah probably, sorry, @petkaantonov |
|
I post a comment on this fix in #1417 |
kenluck2001
reviewed
Jan 21, 2021
| var handleWrapper = new HandleWrapper(setTimeout(function timeoutTimeout() { | ||
| if (ret.isPending()) { |
kenluck2001
reviewed
Jan 21, 2021
| var handleWrapper = new HandleWrapper(setTimeout(function timeoutTimeout() { | ||
| if (ret.isPending()) { | ||
| if (originalPromise.isPending()) { |
There was a problem hiding this comment.
If possible can you add a test to ensure that this code path is protected from future regressions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix race condition described in issue #1417