All changes merged (manually.. ) #73
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterfriese
requested changes
Dec 8, 2021
There was a problem hiding this comment.
Thanks for sending this!
A couple of notes:
- Please use a descriptive title and comment for the PR
- Make sure to use 2-space indent
- Only include what's relevant to issue you're addressing
Apart from this, it doesn't seem like the changes fix the janky animations - particularly, the date picker is still all over the place.
TBH, I am a bit reluctant to work around things that should work out-of-the-box, and would recommend creating an MCVE and file a Feedback with Apple so they fix this for good.
| @@ -0,0 +1,59 @@ | |||
| // | |||
| // Dates.swift | |||
There was a problem hiding this comment.
I wonder why there is an indent before the file name...?
| // Dates.swift | ||
| // MakeItSo | ||
| // | ||
| // Created by Peter Friese, edited by Andrew Cowley on 07/12/2021. |
| @@ -0,0 +1,108 @@ | |||
| // | |||
| // InsetPicker.swift | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Peter, These are the changes we discussed.
-Andrew