This repository has been archived by the owner on Jan 24, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
implement "b3 single" header format #66
Milestone
Comments
@adriancole good deal! I'll see if we can sneak this into v0.4.1 |
Aaronontheweb
added a commit
to Aaronontheweb/Petabridge.Tracing.Zipkin
that referenced
this issue
Dec 31, 2018
Aaronontheweb
added a commit
to Aaronontheweb/Petabridge.Tracing.Zipkin
that referenced
this issue
Jan 2, 2019
Merged
wow lots of tests nicely done
…On Wed, Jan 2, 2019, 10:07 AM Aaron Stannard ***@***.*** wrote:
Closed #66
<#66> via
812ba83
<812ba83>
.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#66 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAD6160FNHop0bK_W8pH_Q0F6eOZYnZfks5u_BRqgaJpZM4WQ8Zb>
.
|
Merged
@adriancole thanks! We don't quite support the sampling flag the way you do in Brave though - we should probably make it into a nullable field so we can explicitly report "not sampled" instead of treating "not set" and "not sampled" as the same thing |
Skipped implementing that in v.0.5.0 because it meant a bunch of API changes that I wasn't quite ready to bite off yet for this release. |
Skipped implementing that in v.0.5.0 because it meant a bunch of API changes that I wasn't quite ready to bite off yet for this release.
ack!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
As discussed on openzipkin/b3-propagation#21 and first implemented here: https://github.com/openzipkin/brave/blob/master/brave/src/main/java/brave/propagation/B3SingleFormat.java https://github.com/openzipkin/brave/blob/master/brave/src/test/java/brave/propagation/B3SingleFormatTest.java
Let's support at least reading "b3" header from a single string, most commonly traceid-spanid-1
It would also be nice to support optionally writing this, especially in message providers or others with constrained environments.
Brave currently has a property like this, but its name could change with feedback:
The text was updated successfully, but these errors were encountered: